Switch Navigator data source to IndexStore#893
Closed
hqhhuang wants to merge 9 commits intoswiftlang:navigator-index-storefrom
Closed
Switch Navigator data source to IndexStore#893hqhhuang wants to merge 9 commits intoswiftlang:navigator-index-storefrom
Navigator data source to IndexStore#893hqhhuang wants to merge 9 commits intoswiftlang:navigator-index-storefrom
Conversation
navigator gets data from IndexStore
Remove `NavigatorDataProvider` and its tests
`flatChildren` should default to null
fix `isFetching` logic
add/fix tests
clean up `getSetting` mock return value
select correct variant for `technologyProp`
create mixin for getting data from the store
minor refinements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://134347681
Summary
This is the 3rd PR of the refactor effort. The navigator should also get its data from
IndexStoreinstead ofNavigatorDataProviderDependencies
#889, merged to the
navigator-index-storebranchTesting
Steps:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded